react-native-google-places icon indicating copy to clipboard operation
react-native-google-places copied to clipboard

[Beta Release] New SDK Alert - Breaking Changes

Open tolu360 opened this issue 5 years ago • 7 comments

Hi Everyone! New SDK has landed with a couple breaking changes for you to be aware of, first off, discard everything you knew about setting up on Android and continue to the beta README

I added securing your keys and working with CI/CD tools to boot - I hope you enjoy this one, a lot of sweat and love went into it.

Cheers, Tolu

tolu360 avatar Mar 11 '19 13:03 tolu360

The beta changes are now stable, please update your apps to v3.0.1 or above. Also, the popularly requested addressComponents property is now cross-platform.

tolu360 avatar May 17 '19 22:05 tolu360

Is photos now supported in RN?

oriharel avatar May 24 '19 08:05 oriharel

When I select place from openAutocompleteModal, I get the address_components. But, it seems like addressComponents not present in getCurrentPlace() response objects.

    "react": "16.8.6",
    "react-native": "0.60.4",
    "react-native-google-places": "3.1.1"

@tolu360 can you please look in to this soon?

UPDATE: I just saw the docs. image

Why can't we get those fields? My requirement is to determine the country. To do it correctly, addressComponents is needed!

malithjkmt avatar Jul 29 '19 06:07 malithjkmt

Hi Malith,

Please read the README, addressComponents are not supported on all methods provided - they are not supported in getCurrentPlace. This is NOT a bug!!

On Mon, Jul 29, 2019, 7:24 AM Malith [email protected] wrote:

When I select place from openAutocompleteModal, I get the address_components. But, it seems like addressComponents not present in getCurrentPlace() response objects.

"react": "16.8.6",
"react-native": "0.60.4",
"react-native-google-places": "3.1.1"

@tolu360 https://github.com/tolu360 can you please look in to this soon?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tolu360/react-native-google-places/issues/198?email_source=notifications&email_token=AA53YZQLNMQUYC6WJZHHOX3QB2EJBA5CNFSM4G5COGK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD27WW7I#issuecomment-515861373, or mute the thread https://github.com/notifications/unsubscribe-auth/AA53YZT5LH3TQGOGHBEPFULQB2EJBANCNFSM4G5COGKQ .

tolu360 avatar Jul 29 '19 08:07 tolu360

Thanks for the quick response. Yes it's not a bug, but can I know that is there any plans to support that on the roadmap ?

malithjkmt avatar Jul 29 '19 08:07 malithjkmt

No such plans. The underlying Google SDKs do not provide it in current place requests, no changes here till if and when that also changes.

tolu360 avatar Jul 29 '19 08:07 tolu360

For more context, see the red notice on the Google docs and feel free to track future changes to those.

tolu360 avatar Jul 29 '19 11:07 tolu360