toolchain icon indicating copy to clipboard operation
toolchain copied to clipboard

breakpad doesn't build on v3.x branch

Open timower opened this issue 1 year ago • 1 comments

Building the toltec image locally always fails at breakpad with:

150.9 Updating src/default.xml due to changed src/DEPS
150.9 Running: gclient root
150.9 Running: gclient config --spec 'solutions = [
150.9   {
150.9     "name": "src",
150.9     "url": "https://chromium.googlesource.com/breakpad/breakpad.git",
150.9     "managed": False,
150.9     "custom_deps": {},
150.9   },
150.9 ]
150.9 '
150.9 Running: gclient sync
150.9 Running: git submodule foreach 'git config -f $toplevel/.git/config submodule.$name.ignore all'
150.9 Running: git config --add remote.origin.fetch '+refs/tags/*:refs/tags/*'
150.9 Running: git config diff.ignoreSubmodules dirty
151.0 error: Your local changes to the following files would be overwritten by checkout:
151.0   default.xml
151.0 Please commit your changes or stash them before you switch branches.
151.0 Aborting

Seems like some dependency wasn't pinned correctly?

timower avatar Sep 28 '23 11:09 timower

I've been running into this as well. I've got a fork I'm working on:

https://github.com/toltec-dev/toolchain/compare/v3.x...chriscohoat:toltec-toolchain:bumping-rust-2024-03-23#diff-b093d34eec92adf6e0cc6e445edb7147ea45d25fb0c98f2f84a60f5aae6f34f7R208

And the closest I've gotten so far is by:

  • Upgrading the toolchain Dockerfile from FROM debian:unstable-20230703-slim to FROM debian:unstable-20240311-slim
  • Replacing git checkout db1cda26539c711c3da7ed4d410dfe8190e89b8f with git checkout v2023.06.01 for breakpad: https://github.com/google/breakpad/releases/tag/v2023.06.01
  • Removing the Python2 references as I'm not sure if they are needed with this breakpad version

I was getting some zlib and zlib1g-dev header issues before upgrading the debian version, which seem to be ok now.

The Dockerfiles seem to build now I just need to confirm that my toltec project can also.

chriscohoat avatar Mar 24 '24 13:03 chriscohoat