toltec icon indicating copy to clipboard operation
toltec copied to clipboard

[rmkit] dependency on 'display' is too strict

Open plan5 opened this issue 1 year ago • 1 comments

Describe the issue All rmkit packages depend on the 'display' package, even though some of them don't actually need it. I specifically have genie and lamp in mind, which could be used without rm2fb if configured well. On recent firmware versions without rm2fb support, this would be nice to have so these packages can be installed without risking a soft brick. Or if one doesn't want to use rm2fb for some reason.

To Reproduce Steps to reproduce the behaviour:

  1. Install genie via opkg
  2. Observe 'display' package being installed as a dependency
  3. (If things go badly with a recent firmware) Soft-brick your device (well, you've been warned but anyhow)/

Expected behaviour rmkit packages that do not need rm2fb do not pull it as a dependency.

Upstream issue None.

Screenshots None

Device/Package information (please complete the following information):

  • Device: reMarkable 2
  • OS version: 3.9.4.2018 rM Hacks v0.0.9
  • Package: rmkit

plan5 avatar Feb 22 '24 22:02 plan5

Toltec doesn't support past 3.9, so we don't plan on making changes to make it easier to work on an unsupported version. We'd much rather work on the changes required to support a new version.

That said, genie and lamp both don't display to the screen themselves, so you are correct, they shouldn't depend upon display. Feel free to open a PR to make the installation dependencies more specific that the maintainer can merge.

Eeems avatar Feb 22 '24 22:02 Eeems