toltec
toltec copied to clipboard
Add support for rm-sync in xochitl package
Recent xochitl versions renamed the sync service and binary to rm-sync. This updates the xochitl package to support both.
@timower poke
@timower poke
Verified on 2.15 (upgrade, fresh install & remove) and 3.5 (fresh install & remove). Seems to work
I cannot build any packages locally anymore, as I'm always running into:
# make xochitl
./scripts/package_build.py "xochitl"
Traceback (most recent call last):
File "/src/./scripts/package_build.py", line 44, in <module>
repo = Repo(paths.RECIPE_DIR, paths.REPO_DIR)
File "/src/scripts/toltec/repo.py", line 60, in __init__
self.generic_recipes[name] = GenericRecipe.from_file(
File "/src/scripts/toltec/recipe.py", line 46, in from_file
return GenericRecipe(name, path, recipe.read())
File "/src/scripts/toltec/recipe.py", line 59, in __init__
variables, functions = bash.get_declarations(definition)
File "/src/scripts/toltec/bash.py", line 147, in get_declarations
assert next_token == "("
AssertionError
I tried different python versions and some docker image, without success.
Python 3.10 is currently required for the toltec build system. Toltecmk supports 3.11, but hasn't been fully updated to do everything the toltec build system does.
@timower unfortunately preupgrade won't run when upgrading from a previous package to this package, only configure from this package runs: https://github.com/toltec-dev/toltec/blob/stable/docs/package.md#install-section
@matteodelabre I'm not sure how the current pre/post upgrade scripts work makes sense as this keeps coming up. It's basically impossible to know what pre/post upgrade steps should be run until you are writing the new package. I think it might be worth us changing this longer term so that pre/post upgrade are run from package B along with configure. That or we start building some standards on what should actually be in those scripts by default in a package.