toltec icon indicating copy to clipboard operation
toltec copied to clipboard

bash-completion for killall doesn't work

Open Eeems opened this issue 1 year ago • 5 comments

Bash completion for killall assumes that ps has -e, -f, and -o, but ps embedded on the device has no flags other than -h. Busybox in entware only adds the -w flag.

/opt/usr/share/bash-completion/bash-completion contains the helper function _pnames that is used to return all possible process names. This will need to be adjusted to work on the rM system, as well as the other helper methods like _pids

Eeems avatar Jul 23 '23 02:07 Eeems

Will take a look at it tomorrow. Probably requires adding a patching the bash-completion package as that on its own was not changed afaik.

LinusCDE avatar Jul 24 '23 00:07 LinusCDE

@LinusCDE did you get a chance to look at this further?

Eeems avatar Jul 31 '23 22:07 Eeems

Didn't get one until now sadly. Still on my todo list. Will try to get to it over the next days. Apologies for the waiting.

LinusCDE avatar Jul 31 '23 23:07 LinusCDE

No worries!

Eeems avatar Jul 31 '23 23:07 Eeems

@LinusCDE have you had time to look into this?

Eeems avatar Dec 06 '23 21:12 Eeems