tolgee-platform icon indicating copy to clipboard operation
tolgee-platform copied to clipboard

feat: Single step import

Open JanCizmar opened this issue 2 years ago • 2 comments

JanCizmar avatar Feb 26 '24 06:02 JanCizmar

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Apr 06 '24 01:04 github-actions[bot]

This PR was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Apr 20 '24 01:04 github-actions[bot]

No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews.

restack-app[bot] avatar May 03 '24 11:05 restack-app[bot]

Requirements for the CLI:

Flow with Tolgee SDK:

  • adding a new key with tag "draft" (or "draft-feature-name") (part of SDK)
  • when releasing, find keys in the code
    • mark all existing as "production" and remove "draft"
    • mark all that were "production" before and are not now as "deprecated" (or "deprecated-in-X.X.X")

Flow without Tolgee SDK:

  • push english translations - all non-existant keys marked as "draft"
  • ... rest is the same
Possible syntax

$ tolgee push ... --tag-new "draft"
$ tolgee tag --filter "extracted" --add "production" --remove "draft"
$ tolgee tag --filter "tag:production & not:extracted" --add "deprecated"

JanCizmar avatar May 10 '24 11:05 JanCizmar

Issue with Apple "STRINGS" format on single-step-import, not accepting the file which was previously exported from the platform (Throwing 500).

Also it would be nice, if we'd merged "STRINGS" and "STRINGSDICT" into "APPLE_STRINGS_STRINGSDICT" as it is in export, so it can be defined on one place in the config.

stepan662 avatar May 10 '24 13:05 stepan662

Seems like filterTagNotIn in export works somehow weirdly - it exports only the namespace, where the tag is and doesn't filter by it.

stepan662 avatar May 14 '24 09:05 stepan662

For the tag command to work, it requires a new parameter filterKeysNot, which will select oposite of listed keys. That way, we can find deprecated keys like this:

tolgee tag --filter-not-extracted --filter-tag production --tag-filtered deprecated

There should also be possibility to mark newly created keys as draft, for which we need parameter in the single-step-import - something like tagCreatedKeys, with list of tags that should be added to newly created keys.

stepan662 avatar May 23 '24 11:05 stepan662

:tada: This PR is included in version 3.62.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar May 31 '24 09:05 github-actions[bot]