tolgee-platform icon indicating copy to clipboard operation
tolgee-platform copied to clipboard

Azure Cognitive machine translation

Open adirh3 opened this issue 1 year ago • 6 comments

Added support for Azure Cognitive machine translation provider (only paid version). First time developing using Kotlin, take that into consideration please.

API docs - https://docs.microsoft.com/en-us/azure/cognitive-services/translator/reference/v3-0-translate#request-url

adirh3 avatar Jul 15 '22 16:07 adirh3

Hello. It looks great. Thanks a lot.

JanCizmar avatar Jul 18 '22 19:07 JanCizmar

Let's see the what the pipeline says. :)

JanCizmar avatar Jul 18 '22 19:07 JanCizmar

Hey. There is a task ./gradlew ktlintFormat, which formats the code automatically. Sometimes it fails due because lines are too long, which you have to fix manually.

JanCizmar avatar Jul 20 '22 06:07 JanCizmar

Hey. There is a task ./gradlew ktlintFormat, which formats the code automatically. Sometimes it fails due because lines are too long, which you have to fix manually.

Thanks! will fix it later this week.

adirh3 avatar Jul 20 '22 13:07 adirh3

Also, to get it released with a version, the commits need to follow conventional commits standard.

https://www.conventionalcommits.org/en/v1.0.0/

So it would be great if the PR was squashed into single commit with feat: prefix.

JanCizmar avatar Jul 26 '22 07:07 JanCizmar

Sorry for my inactivity here. I am currently very busy, so I will look at it hopefully next week.

JanCizmar avatar Aug 01 '22 09:08 JanCizmar

Thanks @JanCizmar! Sorry somehow missed your previous comments.

adirh3 avatar Aug 12 '22 15:08 adirh3

No problem. Probably during next week I will be able to provide the custom API keys feature. :)

JanCizmar avatar Aug 12 '22 15:08 JanCizmar

:tada: This PR is included in version 2.36.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Aug 13 '22 19:08 github-actions[bot]