tolgee-platform icon indicating copy to clipboard operation
tolgee-platform copied to clipboard

Explicit "edited" (or "outdated") state

Open cyyynthia opened this issue 2 years ago • 5 comments

It would be a nice QoL feature to have all translated strings be flagged as outdated when the source string is updated. This would make it easier for translators to spot outdated translations, and to exclude them if necessary when bundling translations into an app.

This could also be used during review, or as a marker for translators who tell themselves "I'll deal with this one later", only to forget about it 😅

cyyynthia avatar May 27 '22 14:05 cyyynthia

Right! "Outdated" is nice term for such a thing. Thanks! :) We were also thinking about setting the status of the translation reviewed -> translated, but adding another field is probably better idea. :)

JanCizmar avatar May 27 '22 14:05 JanCizmar

I'd suggest to have a reviewed status on a version of a translation not on the translation itself.

Flamefork avatar Jul 12 '22 07:07 Flamefork

@Flamefork I think that's a different story. We actually don't store "translation versions", but we store log of changes to selected entities. That's how translation history works.

What Cynthia describes is a basically a problem of modified base translation. (In most cases in english), which is then translated to other languages. Let's say to these things happen:

  1. Developer creates a string in english "Hello World!"
  2. Translator translates it to german as "Hallo Welt!"
  3. Reviewer marks "Hallo Welt!" as Reviewed🟢.
  4. Developer changes the english string to "Hello Universe!"

So now we are in a state when "Halo Welt!" is reviewed, but the base translation means different thing. However, "Hallo Welt" is still correctly spelled and its grammatically correct. What we can do is setting the state of "Hallo Welt" back to Translated🟡, but for many user's who don't use Reviewed🟢 state at all, this wouldn't be enough.

So the only way how to correctly solve this is adding a special indicator, which says "The base translation was changed after last modification of this value".

JanCizmar avatar Jul 12 '22 07:07 JanCizmar

Thanks for the blazingly fast response! And yep, that's a totally different case, sorry for sidetracking it.

Flamefork avatar Jul 12 '22 08:07 Flamefork

I don't think there is an issue opened yet about it, but it seems to me what you're referring to falls under the branching thingy listed on the roadmap, with each branch having a separate state than the base branch. With that, you could have both "Hello World" be reviewed on the base branch, and an updated branch with "Hello Universe", with a different translation and be reviewed too.

cyyynthia avatar Jul 12 '22 13:07 cyyynthia

Design of behavior "Source change indication", "Auto translation indication" and changing state to "Reviewed": https://www.figma.com/file/UCvcqHZe6owmJV5QolBMoj/tolgee-tasks?node-id=1236%3A1433&t=nIZJBNVUQutAMawU-0

ZuzanaOdstrcilova avatar Feb 02 '23 10:02 ZuzanaOdstrcilova