hyper-font-ligatures icon indicating copy to clipboard operation
hyper-font-ligatures copied to clipboard

Upgrade xterm-addon-ligatures for WebGL support

Open jacob-israel-turner opened this issue 3 years ago • 8 comments

See discussions here for context: https://github.com/vercel/hyper/issues/3607#issuecomment-904832810 https://github.com/xtermjs/xterm.js/pull/3286 https://github.com/xtermjs/xterm.js/pull/2847 https://github.com/vercel/hyper/pull/5888

It should still be noted that there are some known issues with ligatures in WebGL (https://github.com/vercel/hyper/issues/5757 and https://github.com/xtermjs/xterm.js/issues/3303). However, it's my opinion that it's still worth using ligatures in WebGL. But users should know that enabling both may result in some rendering glitches.

jacob-israel-turner avatar Sep 05 '21 15:09 jacob-israel-turner

@tolbertam let me know if you have a chance to review this! Happy to make any additional changes you want.

jacob-israel-turner avatar Sep 05 '21 16:09 jacob-israel-turner

As I'm playing with this again, I'm seeing more issues than I thought. Especially while using Vim. The WebGL + Ligature combination appears to be better than what's been released, but people should still be cautious when enabling both.

jacob-israel-turner avatar Sep 05 '21 16:09 jacob-israel-turner

@tolbertam do you have any interest in merging this PR?

jacob-israel-turner avatar Sep 13 '21 15:09 jacob-israel-turner

Came looking here when my Hyper + Hyper-Font-Ligatures + Fira Code + macOS Monterrey stopped working after my Monterrey upgrades (on 2 different MacBooks sharing the same .hyper.js configs). Wondering if merging this PR would fix my issue.

indygwyn avatar Nov 30 '21 19:11 indygwyn

@indygwyn mine also stopped working this morning after updating fira code via brew. In the end it seems that using font-firacode-nerd-font (iirc) instead was the true solution.

jezmck avatar Nov 30 '21 22:11 jezmck

@jacob-israel-turner Deepest apologies for not noticing this until now. Will try to find some time this week to review this and assuming it looks good i'll merge and release it!

tolbertam avatar Jan 05 '22 16:01 tolbertam

@tolbertam have you had a chance to look at this?

gronk-droid avatar Mar 16 '22 18:03 gronk-droid

Hey @tolbertam! Unfortunately I've switched from hyperterm to alacritty, so I won't be pursuing this PR anymore. Feel free to close or use whatever is salvageable.

jacob-israel-turner avatar Dec 07 '22 22:12 jacob-israel-turner