gripmock icon indicating copy to clipboard operation
gripmock copied to clipboard

proto uploads and multi projects proto

Open quintans opened this issue 5 years ago • 5 comments

This is a massive change. I just went crazy :smile: I understand if this gets rejected. Feel free to cherry pick any change.

changes:

  • go modules
  • Uploading proto files
  • Immediate sub directories can represent different imports
  • Packages at the same Level - proto files defined at their own folders and none of them is at the min package (top level)
  • generating *.pg.go into GOPATH

quintans avatar Aug 29 '20 19:08 quintans

haha thankyou for creating this PR, it must be a lot of hardwork. But first, instead of focusing on the chages I am more interested about the motivation for each changes. Like uploading the proto is interesting, but what challenge you face until you made that feature?

Actually one of the issue gripmock has is generated code is placed in the top level. I forgot which issue it is but it's there.

jekiapp avatar Sep 15 '20 06:09 jekiapp

The multi-project support from this MR would actually come super useful. @jekiapp any change an MR with just that change would be accepted?

pcriv avatar Apr 23 '21 12:04 pcriv

Hi @jekiapp, can you merge the feature allowing for proto upload?

cezarypiatekGC avatar Aug 31 '21 08:08 cezarypiatekGC

kudos to @quintans ! I see some pretty useful changes in the PR, but this PR is definitely too huge to merge ... cherry picking from this work is also non-trivial, from current commits ... Probably need to separate the several features into PRs respectively in order to get things moving @jekiapp WDYT

imcom avatar Jun 05 '22 16:06 imcom

Hi guys, sorry for the late replies. This PR is already too old and got a lot of conflicts, it would be impossible for me to merge this. But some of the features are worth to be considered and proposed in a dedicated issue like multi-project and upload protos. For now, if you guys really need what @quintans have been done, you can use his forks instead.

jekiapp avatar Jun 06 '22 03:06 jekiapp