react-native-neomorph-shadows icon indicating copy to clipboard operation
react-native-neomorph-shadows copied to clipboard

ShadowFlex doesn't update on props change

Open xPapla opened this issue 5 years ago • 3 comments

ShadowFlex component does not seem to be processing props change thus not always rendering properly.

This added to ShadowFlex.js seems to fix it.

  componentDidUpdate(_prevProps, prevState) {
    const { style } = this.props;

    if (
      prevState?.shadowStyle?.shadowOffset !== style?.shadowOffset ||
      prevState?.shadowStyle?.shadowOpacity !== style?.shadowOpacity ||
      prevState?.shadowStyle?.shadowRadius !== style?.shadowRadius ||
      prevState?.shadowStyle?.shadowColor !== style?.shadowColor ||
      prevState?.shadowStyle?.borderRadius !== style?.borderRadius ||
      prevState?.shadowStyle?.backgroundColor !== style?.backgroundColor
    )
      this.setState({
        ...prevState,
        shadowStyle: {
          ...prevState?.shadowStyle,
          shadowOffset: style?.shadowOffset,
          shadowOpacity: style?.shadowOpacity,
          shadowRadius: style?.shadowRadius,
          shadowColor: style?.shadowColor,
          borderRadius: style?.borderRadius,
          backgroundColor: style?.backgroundColor,
        },
      });
  }

xPapla avatar Jun 23 '20 01:06 xPapla

Same problem here, is there any updates?

koyin avatar Feb 23 '21 04:02 koyin

I ended up using patch-package and fixed the package using above snippet

xPapla avatar Feb 23 '21 15:02 xPapla

Same problem for me, any updates?

YoniKurtz avatar Apr 21 '21 10:04 YoniKurtz