fuzion icon indicating copy to clipboard operation
fuzion copied to clipboard

We should eventually have separate constants for the various `-1` to improve readability.

Open michaellilltokiwa opened this issue 2 months ago • 3 comments

Looks good in general. We should eventually have separate constants for the various -1 to improve readability.

Originally posted by @maxteufel in https://github.com/tokiwa-software/fuzion/pull/6096#pullrequestreview-3359939001

michaellilltokiwa avatar Oct 21 '25 11:10 michaellilltokiwa

I guess you mean distinct values instead of -1 for NO_SITE, NO_CLAZZ, etc. Took me some time to figure this out.

fridis avatar Oct 21 '25 11:10 fridis

@fridis that too but also e.g. INVALID_LINE = some_random_neg_number instead of -1

michaellilltokiwa avatar Oct 21 '25 12:10 michaellilltokiwa

I did not intend this to mean distinct values instead of -1, but just to define various constants pointing to -1 to mean various things with a descriptive name.

maxteufel avatar Oct 22 '25 09:10 maxteufel