tracing icon indicating copy to clipboard operation
tracing copied to clipboard

Add `record_bytes` to `Visit`

Open mattrutherford opened this issue 4 years ago • 7 comments

Motivation

We use a lot of data that's encoded as bytes that we would like to record to spans and events. While it's possible to use the debug representation, this is not so efficient.

Solution

Add record_bytes method to the Visit trait which defaults to use record_debug in the same way as the existing methods.

mattrutherford avatar Aug 04 '20 21:08 mattrutherford

Since this is a tracing-core change, it would be nice to get @carllerche's approval on this.

hawkw avatar Aug 04 '20 21:08 hawkw

Thanks - if the change is acceptable, I can add more documentation / examples.

mattrutherford avatar Aug 04 '20 22:08 mattrutherford

@hawkw this one would be good to get in some day soon. Anything I can do to help expedite the review here?

:)

dvdplm avatar Nov 03 '20 13:11 dvdplm

I don't have a problem w/ this.

carllerche avatar Nov 03 '20 16:11 carllerche

This is still something that's going to be useful - anything I can do to move it along? Or any concerns?

mattrutherford avatar Jan 07 '21 12:01 mattrutherford

Any news on when this might get merged?

dvdplm avatar Feb 02 '21 22:02 dvdplm

After a rebase, this could probably be merged

bryangarza avatar May 06 '22 00:05 bryangarza