tracing icon indicating copy to clipboard operation
tracing copied to clipboard

Dynamic control over tracing-flame span name

Open jsouto18 opened this issue 4 months ago • 2 comments

Feature Request

Allow for dynamic control over the written span name.

Crates

tracing-flame

Motivation

Currently tracing span names must be 'static. In the use case of running tracing spans over tests configured dynamically we're limited to the same span name.

Proposal

I believe this can be implemented without breaking changes by:

  • Adding a new field to the Config struct defining the name of the span field to be considered as the span name replacement. Here
  • Capturing this field if present and replacing the name write call. Here

I see no drawback for this implementation as of now.

I'm also happy to come up with the PR if this is accepted as a useful feature 😁

jsouto18 avatar Apr 10 '24 11:04 jsouto18

To be clear, what you're proposing is to only change the output of tracing-flame span name, right?

So for example fmt would still output the 'static name and the span names may not be the same for tracing-flame output and other outputs if overridden, right?

mladedav avatar Apr 17 '24 21:04 mladedav

Correct @mladedav!

jsouto18 avatar Apr 18 '24 01:04 jsouto18