tracing icon indicating copy to clipboard operation
tracing copied to clipboard

Published 20 hours ago • verified publisher icon tokio-rs

feat[tracing-subscriber]: extra fields

Open hseeberger opened this issue 1 year ago • 4 comments

Ref #1531. Superseeds #2664.

Currently the trace ID, added to Format, is only serialized for Json.

hseeberger avatar Oct 02 '23 08:10 hseeberger

This is very useful for linking logs to traces. I would love to see it get merged.

NOBLES5E avatar Oct 26 '23 05:10 NOBLES5E

Dear maintainers, please approve the workflow for this PR at least. Reviewing and potentially merging would also be highly appreciated.

hseeberger avatar Oct 26 '23 06:10 hseeberger

Hi, I'll preface this with that I am not a maintainer so I don't have approval rights, I'll just offer some observations. So feel free to ignore any or all of my suggestions.

Anyway, thanks you for this, I really think we need something like this. Are you still open working on this even after the time since you have opened the PR?

I've tried to play around with this and made a test, would you be open to me opening a PR to your branch so that it can be added?

This also currently lacks documentation. Would you be open to me writing something for this?

mladedav avatar Feb 18 '24 20:02 mladedav

any progress on this PR? @mladedav @hseeberger . Would love to get this merged for easier trace_id support.

geekflyer avatar May 31 '24 00:05 geekflyer