tracing icon indicating copy to clipboard operation
tracing copied to clipboard

Published 20 hours ago • verified publisher icon tokio-rs

Replace `atty`

Open dvdplm opened this issue 1 year ago • 3 comments

Feature Request

Crates

tracing-log

Motivation

tracing-log depends on a version of env_logger that is affected by https://github.com/advisories/GHSA-g98v-hv3f-hcfr by way of its dependency on atty (currently unmaintained).

Proposal

Upgrade the env_logger dependency and make a patch release.

dvdplm avatar Sep 22 '23 08:09 dvdplm

It looks like you closed the PR that fixes this?

hawkw avatar Sep 25 '23 19:09 hawkw

@hawkw I'm not sure how to make a PR against a tag (tracing-log-0.1.3 in this case) so I accidentally opened a PR against main (which I closed).

The fix is so minimal (env_logger = { version = "0.10", optional = true }) that I didn't bother to figure out how it's done...

dvdplm avatar Sep 26 '23 13:09 dvdplm

We can close this PR as this has been fixed with commit 4161d8137d4f6117f17b110b0ec022d9350bf8e6 (in pr #2772). Though it still needs to be ported to master :)

kaffarell avatar Dec 06 '23 09:12 kaffarell