tracing icon indicating copy to clipboard operation
tracing copied to clipboard

Consistently pass Dispatch as owned value

Open dvdplm opened this issue 3 years ago • 4 comments

As an alternative to #1045, this PR switches set_default and with_default to take an owned Dispatch instead of a ref.

See comment here for motivation.

Closes #455 Part of #922

dvdplm avatar Oct 19 '20 08:10 dvdplm

It looks like cargo check is failing on this branch because there are merge conflicts which haven't been resolved. Mind rebasing the latest master and fixing that?

hawkw avatar Oct 28 '20 18:10 hawkw

CI failure seems spurious.

dvdplm avatar Nov 03 '20 13:11 dvdplm

@hawkw Is there anything else needed here? :)

dvdplm avatar Dec 14 '20 11:12 dvdplm

Maybe this can still be merged, will need to confirm.

bryangarza avatar May 06 '22 00:05 bryangarza