prost icon indicating copy to clipboard operation
prost copied to clipboard

chore: Bump msrv to 1.70

Open tottoto opened this issue 1 year ago • 5 comments

home 0.5.9 requires Rust 1.70.

tottoto avatar Jan 30 '24 11:01 tottoto

Can you give more context why you think this is needed?

For me, cargo msrv verify reports the MSRV is correct.

$ cargo msrv verify
Fetching index
Verifying the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu
Using check command cargo check
   Finished Satisfied MSRV check: 1.60.0

caspermeijn avatar Feb 09 '24 08:02 caspermeijn

This PR can be closed as the issue is fixed in #982

caspermeijn avatar Feb 16 '24 15:02 caspermeijn

Are there any reason to bump the msrv of the crates which do not depend on home?

tottoto avatar Feb 16 '24 16:02 tottoto

It feels like there is too little maintainer capacity, and I think a single MSRV for the whole repo is easier to maintain. This PR doesn't actually verify the MSRV of main prost crate in CI.

caspermeijn avatar Feb 17 '24 13:02 caspermeijn

This PR doesn't actually verify the MSRV of main prost crate in CI.

Yes, and it has not been performed in this project as well so far.

Bumping the rust-version field make build fail the build lower than its version (without --ignore-rust-version option), and as prost is a widely used crate, it effect is relatively large.

tottoto avatar Feb 17 '24 13:02 tottoto

Let's continue this discussion in #983

caspermeijn avatar Feb 29 '24 09:02 caspermeijn