prost icon indicating copy to clipboard operation
prost copied to clipboard

Use different type parameters for compile_protos arguments

Open nikclayton-dfinity opened this issue 5 years ago • 1 comments

Both type parameters are still AsRef<Path>, but this allows for the first and second arguments to be different types, as long as they both implement AsRef<Path>.

Previously, they had to be the same type. So you couldn't, for example, construct the protos arg as a Vec<String> and the includes arg as a [&str].

nikclayton-dfinity avatar Oct 26 '20 08:10 nikclayton-dfinity

The CI failures do not appear to be related

nikclayton-dfinity avatar Nov 01 '20 12:11 nikclayton-dfinity

This seems to be fixed on latest master

caspermeijn avatar Apr 12 '24 14:04 caspermeijn