io-uring icon indicating copy to clipboard operation
io-uring copied to clipboard

Add missing `register_files` APIs

Open ChillFish8 opened this issue 6 months ago • 5 comments

This PR adds two missing ring calls, io_uring_register_files_tags and io_uring_register_files_update_tag.

Tests have been added and confirmed working, I also adjusted part of the docs for register_files to more accurately note the behaviour of the call.

ChillFish8 avatar May 31 '25 23:05 ChillFish8

I thought I could get away with not waiting on the completions but I guess CI is just slow enough to run into the completions not being registered in time. Should be fixed now along with linting.

ChillFish8 avatar Jun 01 '25 11:06 ChillFish8

@quininer can you cancel the last run, it is deadlocked and will just be waiting forever, I've changed the way it waits for completions to use an event FD which should reliably wake up.

ChillFish8 avatar Jun 01 '25 12:06 ChillFish8

Hopefully the last fix on the tests :crossed_fingers:

ChillFish8 avatar Jun 01 '25 17:06 ChillFish8

You can also create new IoUring instances for specific test cases.

quininer avatar Jun 02 '25 02:06 quininer

I was hoping to avoid that, we can give it a go, but I believe it shouldn't be timing out the runners like that with the eventfd approach so will need to look into it a bit more.

ChillFish8 avatar Jun 02 '25 11:06 ChillFish8