dbcat icon indicating copy to clipboard operation
dbcat copied to clipboard

Published 20 hours ago • verified publisher icon tokern

Added sqlserver support

Open marqueewinq opened this issue 1 year ago • 3 comments

Hi @vrajat! We would like to use piicatcher with our internal workflows; in order to do that we need to support SQLServer. We have already contributed to dbcat in https://github.com/tokern/dbcat/pull/67, now we would like to make another set of similar changes.

I see that SQL Server support was removed from piicatcher because pymssql was no longer supported: https://github.com/tokern/piicatcher/pull/74. However, it seems that it is now supported again: https://github.com/pymssql/pymssql/issues/668. So, i would like to add it again if you don't mind.

  • Added sqlserver support
  • Some tests

Let me know if i can make this PR better! :heart:

marqueewinq avatar Jan 15 '24 08:01 marqueewinq

Hi @vrajat, can i improve this in any way?

marqueewinq avatar Jan 17 '24 09:01 marqueewinq

Hi @vrajat, i am sorry to disturb you, but can you take a look at this please?

marqueewinq avatar Jan 22 '24 11:01 marqueewinq

Hi @jhecking can we merge this?

marqueewinq avatar Feb 08 '24 13:02 marqueewinq