yaque icon indicating copy to clipboard operation
yaque copied to clipboard

feat: allow for disabling crossbeam-channel

Open raphaelcoeffic opened this issue 1 year ago • 4 comments

As it turns out, tokio does not mix well with notify when crossbeam-channels are enabled (see here).

In my tests with yaque added this way to my deps, it seems to work as expected (with this PR in place):

yaque = { version = "0.6.6", default-features = false, features = ["no-crossbeam-channel"] }

Fixes #32

raphaelcoeffic avatar Feb 15 '24 16:02 raphaelcoeffic

I can't believe it's that simple! Do you have any resources on this funky behavior?

EDIT: Sorry! I saw the link in your comment.

tokahuke avatar Feb 15 '24 17:02 tokahuke

wow

alexander-camuto avatar Feb 15 '24 20:02 alexander-camuto

So, I will merge and create a new minor version tomorrow, when I have some time to look into this closely.

tokahuke avatar Feb 16 '24 20:02 tokahuke

So, I will merge and create a new minor version tomorrow, when I have some time to look into this closely.

Thx a lot for your time!

raphaelcoeffic avatar Feb 19 '24 06:02 raphaelcoeffic