sqm-scripts icon indicating copy to clipboard operation
sqm-scripts copied to clipboard

functions.sh: make IFB interface name configurable

Open intelfx opened this issue 10 months ago • 4 comments

Accept a new variable $IFB_PATTERN which is used as a printf(1) pattern to generate the IFB interface name from the primary interface name. The default is ifb4%s which corresponds to the pre-existing behavior.

Signed-off-by: Ivan Shapovalov [email protected]

intelfx avatar Jan 27 '25 03:01 intelfx

Out of curiosity, what is the motivation for this?

moeller0 avatar Jan 27 '25 06:01 moeller0

Out of curiosity, what is the motivation for this?

Some less-than-configurable monitoring software that uses hardcoded patterns of ignored interface names. There is a pattern for ifb interfaces, but it does not match ifb4*.

intelfx avatar Jan 27 '25 06:01 intelfx

Fair, may I ask to maybe add this to the commit description (maybe even reveal that monitoring software's name)? So far the fixed naming for sqm created IFBs has helped in the past to detect cases where users accidentally tried multiple traffic shaping solutions in parallel...

moeller0 avatar Jan 27 '25 07:01 moeller0

Yes, please document the reason for the change in the commit message :)

tohojo avatar Jan 27 '25 11:01 tohojo