toge

Results 80 comments of toge

@kobalicek Thanks a lot!

@uilianries Now cross compiling for M1 macOS works fine. However, compiling with MSVC fails. I think I can compile it because upstream has an issue on MSVC, but I couldn't...

@uilianries Thanks a lot! I try them.

I have given up support for Windows...

@fpelliccioni ParlayHash API has been changed since 0.0.2 and does not work well with the latest test_package.cpp. Please replace test_package.cpp with the following code. https://github.com/cmuparlay/parlayhash/blob/v0.0.2/examples/example.cpp

@fpelliccioni As you have already raised an issue on upstream, 0.1.0 has been released and appears to support MSVC. Would you update this PR to 0.1.0?

@fpelliccioni Thanks you for your contribution! These error is caused by several temporary files in release files. (#hash_table.h#, #primitives.h#, ...) These files is commited in upstream repository. https://github.com/cmuparlay/parlayhash/tree/v0.1/include/parlay Could you...

@fpelliccioni oh no. CI seems to fail starting. Please restart again by clicking "update branch" if possible.

@fpelliccioni ``` include/parlay_hash/parlay_hash.h:644:12: error: reference to local binding 'tag' declared in enclosing function 'parlay::parlay_hash::Find' if (b->lv(tag)) return find_in_list(s.overflow_list(), k, f).first; ^ ``` It seems to be caused by lack of...

oh. In my local environment(17.7.2+d6990bcfa), it works fine. I try to find workaround.