minecloud-ami icon indicating copy to clipboard operation
minecloud-ami copied to clipboard

Minecraft 1.7.2

Open wilg opened this issue 11 years ago • 4 comments

Looks like @dmotles made some changes for Minecraft 1.7.2, would be nice if they were in the base repo.

wilg avatar Dec 30 '13 19:12 wilg

Just an FYI, while this fix indeed did seem to work ok (tested it with some of my buddies on our server and player tracking worked), it's likely a bit over-engineered for what the fix needs to do. It's better than nothing, but it could probably be better. I just haven't played minecraft in a while and thus never revisited this project.

dmotles avatar Dec 30 '13 19:12 dmotles

@dmotles Thanks for your fixes!

@wilg If you get a chance to try these fixes, I'm interested in hearing how they work out for you. Unfortunately, I won't get a chance to test them out myself in the near future.

toffer avatar Dec 31 '13 07:12 toffer

I'm running them currently, and I haven't noticed anything yet.

wilg avatar Dec 31 '13 07:12 wilg

I've continued to run these changes and haven't noticed any serious issues. There are occasionally times where it's not quite up-to-date but it's never caused a problem.

It's certainly better than no player information at all without this fix, so I'd recommend merging it.

wilg avatar Feb 09 '14 22:02 wilg