blocksuite icon indicating copy to clipboard operation
blocksuite copied to clipboard

fix(edgeless): toolbar nav next button's size should be 20*20

Open CatsJuice opened this issue 1 year ago • 4 comments

previous:

CleanShot 2024-07-29 at 17.19.57@2x.png

CatsJuice avatar Jul 29 '24 09:07 CatsJuice

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Jul 29 '24 09:07 graphite-app[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 5:55am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 5:55am

vercel[bot] avatar Jul 29 '24 09:07 vercel[bot]

  • #7753 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

CatsJuice avatar Jul 29 '24 09:07 CatsJuice

It may be caused by this: https://github.com/toeverything/blocksuite/blob/3b62f7a91e89e364342764c7f9d941ccda8ac331/packages/blocks/src/_common/components/button.ts#L103-L104

But it is not reasonable to set svg itself to 32x32.

fundon avatar Jul 29 '24 23:07 fundon

I think the reason is that the icon is changed

CleanShot 2024-08-01 at 12 06 11@2x

CleanShot 2024-08-01 at 12 05 30@2x

L-Sun avatar Aug 01 '24 04:08 L-Sun

Merge activity

  • Aug 1, 1:29 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 1, 1:29 AM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
  • Aug 1, 1:47 AM EDT: Saul-Mirone merged this pull request with the Graphite merge queue.

graphite-app[bot] avatar Aug 01 '24 05:08 graphite-app[bot]