blocksuite icon indicating copy to clipboard operation
blocksuite copied to clipboard

fix(database): can't remove selected text cell contents with backspace

Open golok727 opened this issue 1 year ago • 3 comments

https://github.com/toeverything/blocksuite/assets/123532141/7795c603-8281-4a54-80a9-760981e0cfb7

golok727 avatar Apr 26 '24 12:04 golok727

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 9:04am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 9:04am

vercel[bot] avatar Apr 26 '24 12:04 vercel[bot]

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Apr 26 '24 12:04 graphite-app[bot]

@zzj3720 getValue function for the title cell returns Y.Text and the text cell returns Text should we make it consistent as both are rich text? https://github.com/toeverything/blocksuite/blob/c8e5f897c76cf6f4697992cc9f0d160c29a6b7eb/packages/blocks/src/database-block/data-source.ts#L103-L120

golok727 avatar Apr 26 '24 12:04 golok727

getValue function for the title cell returns Y.Text and the text cell returns Text should we make it consistent as both are rich text?

I have made them consistent in this PR https://github.com/toeverything/blocksuite/pull/6918. It seems that #6918 also fixed this issue.

zzj3720 avatar Apr 29 '24 09:04 zzj3720

getValue function for the title cell returns Y.Text and the text cell returns Text should we make it consistent as both are rich text?

I have made them consistent in this PR #6918. It seems that #6918 also fixed this issue.

👍🏻Closing!

golok727 avatar Apr 29 '24 10:04 golok727