blocksuite icon indicating copy to clipboard operation
blocksuite copied to clipboard

fix(std): prevent unexpected touch behavior

Open EYHN opened this issue 10 months ago • 3 comments

Currently, unexpected drags will be triggered on touch screens.

I recommended to ignore touch events until we implement better touch logic.

EYHN avatar Apr 19 '24 02:04 EYHN

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 2:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 2:18pm

vercel[bot] avatar Apr 19 '24 02:04 vercel[bot]

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Apr 19 '24 02:04 graphite-app[bot]

  • #6818 Graphite 👈
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

EYHN avatar Apr 19 '24 02:04 EYHN

My suggestion is that we should not introduce changes before adding support for touch screens.

Saul-Mirone avatar May 09 '24 06:05 Saul-Mirone

I think we need to support a "read-only" mode like other products, as the reading experience on mobile devices is very poor now.

image

Flrande avatar May 09 '24 12:05 Flrande

I think we will eventually need to rewrite a completely different set of operation logic for touch, and before that it is appropriate to completely separate pointer events from touch events.

The result of this change is acceptable to me (can do simple text editing), but it may make some operations that were previously possible with the touch screen unavailable (the toolbar is not clickable).

EYHN avatar May 09 '24 14:05 EYHN