blocksuite icon indicating copy to clipboard operation
blocksuite copied to clipboard

Switch to custom cursor icon

Open hwangdev97 opened this issue 2 years ago • 7 comments

IMG_5720

hwangdev97 avatar Sep 18 '23 02:09 hwangdev97

Can you elaborate on this a little bit, is that cursor too large or too fuzzy?

doouding avatar Sep 19 '23 02:09 doouding

I found Figma uses custom cursors to ensure visual consistency. I think we can use the same approach.

doouding avatar Sep 20 '23 14:09 doouding

Please replace drag and drop hand as the Figma shown @doouding DropCursor DragCursor

Svaney-ssman avatar Sep 22 '23 08:09 Svaney-ssman

How about adding the drag&drop cursor to the @toeverything/theme package?

doouding avatar Sep 25 '23 09:09 doouding

We should change the UI performance on windows to specifically fix this issue. If necessary, add it to package.

hwangdev97 avatar Sep 25 '23 12:09 hwangdev97

We don't have to make it a Windows-specific solution. Instead, we can make the cursor: grab and cursor: grabbing using custom cursor inside the BlockSuite project components in this way:

.element-grab {
    cursor: url('path/to/grab-icon.cur'), grab;
}

.element-grabbing {
    cursor: url('path/to/grabbing-icon.cur'), grabbing;
}

doodlewind avatar Dec 04 '23 10:12 doodlewind

We don't have to make it a Windows-specific solution. Instead, we can make the cursor: grab and cursor: grabbing using custom cursor inside the BlockSuite project components in this way:

.element-grab {
    cursor: url('path/to/grab-icon.cur'), grab;
}

.element-grabbing {
    cursor: url('path/to/grabbing-icon.cur'), grabbing;
}

The custom grabbing cursor has already been added to the @toeverything/design package. I forgot to replace it in the BlockSuite.

doouding avatar Dec 04 '23 11:12 doouding