todo.txt-cli icon indicating copy to clipboard operation
todo.txt-cli copied to clipboard

Added warning message for todo.sh archive

Open chrysle opened this issue 3 years ago • 2 comments

I have added a warning message which todo.sh archive will print out if it does not find done tasks in the todo file. Before, it would even then print TODO: ./todo.txt archived.

Before submitting a pull request, please make sure the following is done:

  • [x] Fork the repository and create your branch from master.
  • [x] If you've added code that should be tested, add tests!
  • [x] Ensure the test suite passes.
  • [x] Format your code with ShellCheck.
  • [x] Include a human-readable description of what the pull request is trying to accomplish.
  • [ ] Steps for the reviewer(s) on how they can manually QA the changes.
  • [ ] Have a fixes #XX reference to the issue that this pull request fixes.

chrysle avatar Dec 18 '22 14:12 chrysle

Should I squash my commits?

chrysle avatar Dec 21 '22 16:12 chrysle

You can squash if you want to, but there's no need. The change is looking fine now, thanks a lot!

It'll probably still take some time (at least until January) until this gets merged, we currently have a bit of a backlog of PRs, but @karbassi has a New Year's resolution of devoting some time to this project, and we'll very likely also do a fresh release then ;-)

inkarkat avatar Dec 21 '22 18:12 inkarkat