Two "typos" in IPC::Run::IO::new [rt.cpan.org #111214]

[toddr]

trafficstars

Migrated from rt.cpan.org#111214 (status was 'new')

Requestors:

• [email protected]

From [email protected] on 2016-01-15 16:16:34:

sub new {
   my $class = shift;
   $class = ref $class || $class;

   my ( $external, $type, $internal ) = ( shift, shift, pop );

   croak "$class: '$_' is not a valid I/O operator"
 <---------------- << $_ >> should be << $type >>
      unless $type =~ /^(?:<<?|>>?)$/;

   my IPC::Run::IO $self = $class->_new_internal(
      $type, undef, undef, $internal, undef, @_
   );

   if ( ! ref $external ) {
      $self->{FILENAME} = $external;
   }
   elsif ( ref eq 'GLOB' || UNIVERSAL::isa( $external, 'IO::Handle' ) ) {
 <---------------- << ref eq 'GLOB' >> should be << ref( $external ) eq
'GLOB' >>
      $self->{HANDLE} = $external;
      $self->{DONT_CLOSE} = 1;
   }
   else {
      croak "$class: cannot accept " . ref( $external ) . " to do I/O with";
   }

   return $self;
}

This also means that there are no tests for $io = io( *HANDLE, '<', $send );

[toddr]

@ikegami What patch are you recommending here?

[ikegami]

hmmm? It's pretty clearly stated in the previous message. Change << $_ >> to << $type >>, and change << ref eq 'GLOB' >> to << ref( $external ) eq 'GLOB' >>