IPC-Run icon indicating copy to clipboard operation
IPC-Run copied to clipboard

docs of kill_kill() return value

Open toddr opened this issue 7 years ago • 1 comments
trafficstars

https://rt.cpan.org/Public/Bug/Display.html?id=123274

Date: | Sat, 14 Oct 2017 12:37:20 +1100 To: | bug-IPC-Run [...] rt.cpan.org From: | Kevin Ryde <user42_kevin [...] yahoo.com.au>

The docs of IPC::Run 0.96 say kill_kill()

Returns a 1 if the "TERM" was sufficient, or a 0 if "KILL" was
required.

but running the code it is undef and 1 respectively. Sample program below. The first TERM suffices, the second ignores TERM and needs KILL.

use strict;
use IPC::Run;
foreach my $sh ('sleep 10',
                'trap "" TERM; sleep 10') {
  my $ipc = IPC::Run::start(['sh','-c',$sh]);
  sleep 1;
  my $ret = $ipc->kill_kill(grace=>1);
  print defined $ret ? $ret : "[undef]", "\n";
}

toddr avatar Mar 26 '18 21:03 toddr

This seems to be a request for a documentation fix. I assume we need to clarify that this is a truthy response rather than 0/1.

If this is not the case, let me know.

toddr avatar Mar 26 '18 22:03 toddr