todc-bootstrap icon indicating copy to clipboard operation
todc-bootstrap copied to clipboard

Don't include *.map in dist/css/todc-bootstrap.css, have a debug build

Open knownasilya opened this issue 10 years ago • 6 comments

So todc-bootstrap.css shouldn't be a debug build by default, maybe have a todc-bootstrap.debug.css which has the source map included.

This is mainly due to using that file with other files in an app, and usually we bring in the non-minified version and minify things for production only. We generate our own source maps when needed, so this is kind of a hassle, since we need to use the min version (or edit the file, which is hardly acceptable).

knownasilya avatar Oct 13 '14 14:10 knownasilya

This project currently follows the way that bootstrap handles it since this project requires bootstrap. How do you handle the bootstrap map?

acmetech avatar Oct 13 '14 17:10 acmetech

I use their less build, but your less build is broken last I checked.

knownasilya avatar Oct 13 '14 17:10 knownasilya

I haven't received any reports of the build process being broken. What issues are you having? Did you take a look at this? https://todc.github.io/todc-bootstrap/getting-started/#grunt

acmetech avatar Oct 13 '14 17:10 acmetech

@acmetech not the build process, I include the bootstrap.less directly into my less file, and you can't do that with todc, since it requires bootstrap for you with a relative path that can't be changed.

knownasilya avatar Oct 13 '14 18:10 knownasilya

You'll either need to customize todc-bootstrap.less or include the todc-bootstrap components in your less directly.

acmetech avatar Oct 13 '14 18:10 acmetech

How custom builds are handled may change in the next major release, v4. This is dependent, at least partially, on how bootstrap is going to handle themes in BS v4.

Your options are to customize the grunt task, customize the less build, or manually edit the css.

acmetech avatar Oct 13 '14 18:10 acmetech