blink1 icon indicating copy to clipboard operation
blink1 copied to clipboard

Need new Python version on PyPi

Open HondoOhnaka opened this issue 9 years ago • 15 comments

I'm confused as it looks like this has been updated more recently than the "official" version fork by @salimfadhley . It looks like his fork has solved the missing init.py file for the python module.

But it has not been updated on PyPi since last June.

Can someone step up and address this and get the latest version bumped so it can be imported as a module?

Relates to: https://github.com/todbot/blink1/issues/140

HondoOhnaka avatar Mar 19 '15 00:03 HondoOhnaka

salim's version is the official one, this is just a mirror. As far as I know there's nothing new in this repo.

His version is only for Python 3 I think though.

todbot avatar Mar 19 '15 01:03 todbot

I've not done any work on this in months - is there a specific change you need? I can have a go.

salimfadhley avatar Mar 23 '15 10:03 salimfadhley

@salimfadhley see https://github.com/todbot/blink1/issues/140. The library no longer works on python2 because of it. After pip install, import still fails:

+ ~/Work/francois-poneys/blink1 on master* $ python
Python 2.7.10 (default, Jun 10 2015, 19:42:47) 
[GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
+>>> import blink1
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named blink1

franc0is avatar Sep 05 '15 18:09 franc0is

I have not played with this for ages - I can give it a once over sometime this week.

On Sat, 5 Sep 2015 19:41 François Baldassari [email protected] wrote:

@salimfadhley https://github.com/salimfadhley see #140 https://github.com/todbot/blink1/issues/140. The library no longer works on python2 because of it. After pip install, import still fails:

  • ~/Work/francois-poneys/blink1 on master* $ python Python 2.7.10 (default, Jun 10 2015, 19:42:47) [GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin Type "help", "copyright", "credits" or "license" for more information. +>>> import blink1 Traceback (most recent call last): File "", line 1, in ImportError: No module named blink1

— Reply to this email directly or view it on GitHub https://github.com/todbot/blink1/issues/219#issuecomment-137985740.

salimfadhley avatar Sep 05 '15 18:09 salimfadhley

getting bit by this as well :(

jjshoe avatar Apr 19 '16 00:04 jjshoe

hey @salimfadhley, I could make these changes if you point me at the basics of how to generate content for PyPi (or make me a contributor if PyPi supports such a concept, my PyPi id is 'todbot')

todbot avatar Apr 19 '16 00:04 todbot

An additional complication is he doesn't appear to have issues turned on for that repo?

jjshoe avatar Apr 19 '16 01:04 jjshoe

Okay - I can make Todd the project owner and also do a release. It won't be until late tonight.

Todd what is your username

On Tue, 19 Apr 2016 02:27 jjshoe, [email protected] wrote:

An additional complication is he doesn't appear to have issues turned on for that repo?

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/todbot/blink1/issues/219#issuecomment-211673623

salimfadhley avatar Apr 19 '16 05:04 salimfadhley

Hi @salimfadhley, my PyPi username is "todbot".

todbot avatar Apr 19 '16 06:04 todbot

Todd, you have been added as a project publisher.

I've just joined a team within Bank of America that's a keen user of Blink1 mk2 lights. I'm going to add my two to the collection and hopefully use this as an excuse to improve our software.

Now remind me - whose version is the official version these days? My preference would be to kill off my version of the software since I think it's confusing to have somebody other than the blink1 company holding the official version of the software.

Have you any idea what it is I'm supposed to be fixing. Sorry - totally out of it! :-)

On Tue, 19 Apr 2016 at 07:30 Tod E. Kurt [email protected] wrote:

Hi @salimfadhley https://github.com/salimfadhley, my PyPi username is "todbot".

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/todbot/blink1/issues/219#issuecomment-211755716

salimfadhley avatar Apr 19 '16 21:04 salimfadhley

Hi Salim, No problem, I understand about lack of time!
I think there are two main issues:

  1. The version on PyPi is from your fork of this repo, but issues with that version come here, and
  2. This library is Python 3 only and many people want it to work with Python 2.

My questions to you are:

  1. Where is there a good doc on how to publish to PyPi?
  2. How hard is it to make this library work with Python 2?

Thanks!

todbot avatar Apr 20 '16 03:04 todbot

I will make a script with all the publishing logic

Making if python compatible should be easy as long as the USB libraries ate functionally the same.

On Wed, 20 Apr 2016 04:00 Tod E. Kurt, [email protected] wrote:

Hi Salim, No problem, I understand about lack of time!

I think there are two main issues:

  1. The version on PyPi is from your fork of this repo, but issues with that version come here, and
  2. This library is Python 3 only and many people want it to work with Python 2.

My questions to you are:

  1. Where is there a good doc on how to publish to PyPi?
  2. How hard is it to make this library work with Python 2?

Thanks!

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/todbot/blink1/issues/219#issuecomment-212226530

salimfadhley avatar Apr 20 '16 05:04 salimfadhley

Is this still active? There are several bugs in the python3 blink1 module from pypi that are fixed in this repo. Will there be an update in pypi?

jklmnn avatar Jul 05 '17 10:07 jklmnn

Sorry - I've not really touched it in ages. I've been meaning to!

I suggest that you take a look at the source code. Perhaps you'd like to have a go at it!

On Wed, 5 Jul 2017 at 11:02 JK [email protected] wrote:

Is this still active? There are several bugs in the python3 blink1 module from pypi that are fixed in this repo. Will there be an update in pypi?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/todbot/blink1/issues/219#issuecomment-313059413, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvzWTAFab41oRgdTrhCp_DRhQoYYjhvks5sK181gaJpZM4DxCxk .

salimfadhley avatar Jul 05 '17 15:07 salimfadhley

Well the bugs I mean are all fixed in this repo. All that would be required is to update your repo with the contents of this one or use this one to create the pypi package (which I would prefer since this repo is also on the Blink1 library page). EDIT: If you wan't to I can specifically point out the bugs I mean, but I think there might be more that doesn't affect me and that are also fixed here.

jklmnn avatar Jul 07 '17 13:07 jklmnn