libtock-rs icon indicating copy to clipboard operation
libtock-rs copied to clipboard

WIP: Implement block storage API basics

Open dcz-self opened this issue 3 years ago • 3 comments

This is a synchronous API for the proposed block storage syscall. It's enough to test it.

TODO:

  • write tests

Tested on the SMA Q3 as described in https://github.com/tock/tock/pull/3162

dcz-self avatar Aug 25 '22 12:08 dcz-self

How to format the files correctly? 0de4540801990c020a54e90a23c14ee7b98314e8 is the result of running cargo fmt on my side, but the CI is clearly configured with some other formatting rules. Unfortunately, it's not clear to me what rules and how to apply them to my commit for submission.

dcz-self avatar Aug 25 '22 14:08 dcz-self

How to format the files correctly? 0de4540 is the result of running cargo fmt on my side, but the CI is clearly configured with some other formatting rules. Unfortunately, it's not clear to me what rules and how to apply them to my commit for submission.

I suspect you misread the CI output. I see a LIBTOCK_PLATFORM=nrf52 cargo fmt --all -- --check invocation that succeeded and produced no output followed by a cargo clippy --all-targets --exclude libtock --exclude libtock_runtime --exclude libtock_debug_panic --exclude libtock_small_panic --workspace invocation that errored.

Or maybe you are looking at an older CI run I don't see? If so, please link the failed CI. I think that cargo fmt --all should Just Work (TM).

jrvanwhy avatar Aug 25 '22 16:08 jrvanwhy

Thanks, I looked at a stale run for some reason. It should be clean now.

dcz-self avatar Aug 25 '22 17:08 dcz-self

Closing due to inactivity.

jrvanwhy avatar Aug 29 '23 16:08 jrvanwhy