libtock-c icon indicating copy to clipboard operation
libtock-c copied to clipboard

move lora examples to legacy directory

Open bradjc opened this issue 1 year ago • 1 comments

The main change here is moving the lora examples to a folder where they are not on the critical path for building and passing CI. For #370 we are updating libtock, but these apps use code that references libtock in a different library. To make progress on #370 this makes them not have to build.

The folder doesn't have to be called "legacy", that is just the first idea I had.

bradjc avatar Apr 12 '24 17:04 bradjc

I'm not sure I follow. Why remove this from the CI?

The LoRa stuff works really well. It's probably the most reliable wireless support Tock has. It's also not WIP, the actual LoRa code is very robust. I have a PR open to transmit GNSS data as well

alistair23 avatar Apr 13 '24 10:04 alistair23

Why remove this from the CI?

We need it to support RISC-V, and we need to be able to update libtock function names without patching a different library.

bradjc avatar Apr 15 '24 19:04 bradjc

Do you have a RISC-V board with LoRa? There isn't any reason it won't support RISC-V

Are we really changing the libtock-c APIs so often that we can't call them from external libraries? That makes using libtock-c for anything besides test examples really hard

alistair23 avatar Apr 16 '24 04:04 alistair23

Are we really changing the libtock-c APIs so often that we can't call them from external libraries?

Yes and no. We are changing them (they really need to be updated). But an external library can pin to a version. The issue is the circle in the lora examples.

bradjc avatar Apr 16 '24 15:04 bradjc