Toby Zerner
Toby Zerner
@franzliedke no we're talking about json-api-php/json-api
Now that we require PHP 7 in Flarum, no reason we can't build next version of tobscure/json-api on top of it :)
Interesting, thanks for pointing this out. I'm open to exploring this. I'll play around with it when I have some time.
One issue (inconvenience?) I can see, at least in the context of Laravel and other environments with a similar dependency injection container: What if I want to inject dependencies into...
🤦♂️ I always forget about factories... that's a good solution. Well, I think I'm all for this then. Feel free to send a PR if you're up for it? Otherwise,...
@f3ath and let me know if you are, so we don't double up :)
Alright! I've got something working. I had to rewrite most of the document-construction logic — which was a bit of a mess anyway — and now it's a lot simpler...
Aaaand just squeezed out an extra drop of performance and made the algorithm even simpler. Did some basic benchmarks. New version is 2x faster for a simple document, 3x faster...
@franzliedke tomorrow!
@franzliedke #119