Toby Murray

Results 28 comments of Toby Murray

Sorry, that was a bit misleading, I didn't want to overwhelm the post with details. I think where I went off the rails is answered by: currently Tera does _not_...

Hmm - I'll have to give it a shot, maybe I did something silly like omit a character...

I'm using Tokio, so I guess I can do e.g.: ``` c.register("job_type", |job| -> io::Result { let runtime = Runtime::new()?; runtime.block_on(async_handler(job)); Ok(()) }); ```

Adding another anecdote supporting the "I'm confused" position. I acknowledge that upon rereading "Consecutive elements that map to the same key (“runs”), are assigned to the same group." it lines...

I don't feel like I understand why `group_by` as it exists today is actually useful in practice, so I'm not sure I can suggest a descriptive name. Is it a...

I think I understand the implementation and that it can theoretically be more efficient if the data is sorted or the aggregated groups aren't actually needed, I'm just not sure...

> I'm wondering if we could just clarify the documentation enough to avoid any weirdness. My instinctual reaction is "no, this can't effectively be fixed by documentation". I think the...

I think that naming debate has settled? The PR is up for standard library to use `chunk_by`, i.e.. https://github.com/rust-lang/rust/pull/117678