18xx icon indicating copy to clipboard operation
18xx copied to clipboard

Deprecate can_act?

Open daniel-sousa-me opened this issue 2 years ago • 0 comments

On line 66 of lib/engine/round/base.rb, it says that can_act? is deprecated. But it is being called a few times elsewhere.

Should these be replaced by something else?

Line 44 of assets/app/view/game/entity_list.rb is underlining @acting_entity == entity || @round.can_act?(entity). I want to underline a specific corp on context_entities that isn't currently active (it's just a context), so I'm passing it as the @acting_entity. But can_act? is also underlining the one that is currently acting and that doesn't make any sense.

Can I remove it from there? EntityList should be more general than that (maybe @acting_entity needs to be a list)

daniel-sousa-me avatar Jun 10 '22 19:06 daniel-sousa-me