[18Neb] P1 and P4 tile reservation UI (bars) s.b. removed in phase 3

[BellmakerSA]

http://18xx.games/game/157964?action=152

C&S was able to build on B8 while I owned P1 which should not be allowed.

https://gist.github.com/benjaminxscott/48373f4fcc304eb8212f230326288661

[benjaminxscott]

Looks like this is operating as expected, the rules indicate P1 (DPR) as well as P4 only block their respective hexes until phase 3 (green)

We should remove the bars on the tile in phase 3, it's likely the UI doesn't remove those since idk if there are any other games that work that way

We should also add that info to the private descriptions

[scottredracecar]

1861 has a rule like that too for all the privates that block hexes.

On Thu, Mar 28, 2024 at 9:57 AM Benjamin Scott @.***> wrote:

Looks like this is operating as expected, the rules indicate P1 (DPR) as well as P4 only block those hexes until phase 3 (green)

We should remove the bars on the tile in phase 3, it's likely the UI doesn't remove those since idk if there are any other games that work that way

We should also add that info to the private descriptions

— Reply to this email directly, view it on GitHub https://github.com/tobymao/18xx/issues/10571#issuecomment-2025688424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6CEXGJSR5VUR4XB5BYZVTY2RDWLAVCNFSM6AAAAABFM5ZCHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVGY4DQNBSGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[crericha]

Okay, will remove reservations. @scottredracecar thanks for the tip on what game I can mimic.

[crericha]

Found out that the blocks_hexes ability (for all games) doesn't remove the block from the hex during its teardown. I fixed the core code.