[1828.Games] Directorship is sometimes assigned to the wrong player in System formation

[physic]

https://18xx.games/game/156937?action=898

When merging into a system, if two players own the same number of shares of the constituent companies, and that number is odd, and both players trade up the share, the directorship is given to the wrong player (and then the wrong player is required to donate a share to the System).

Specifically, if after exchanging shares but before donating a share, the acting player holds an equal number of shares to another player, the acting player is the director, regardless of the order of any share exchanges.

In this scenario, the acting player exchanges half shares last, and so they get to their current share count after the other player, so applying typical change of directorship rules would result in this bug. The step after share exchange in the merger process calls out an exception to the typical change of directorship rules.

Relevant rules From 7.5.2 Merger Process (Step 10):

10. The director of the new system must donate a 10%
share certificate that they own of the new system
to the new system’s charter (see 7.5.2.2 & section 13.4).
– The currently active player is the director of the
new system unless another player owns more
shares of the new system

I spoke with JCL, and he confirmed that the first bullet point of section 10 is intended to take precedence over any potential change of directorship that may occur during the share exchange process. The fact that the other player got their 3rd share first is not relevant.

Scenario I have 5 shares of the MC. KZ has 5 shares of the NKP. On my turn, I merge my MC with his NKP (with consent). He is offered a chance to trade up his odd share, and he does so. I am offered a chance to trade up my odd share, and I do so.

Expected We each have three shares. I am the director. I donate a share to the company. Now I have two shares, and he is the director.

Observed (the opposite) We each have three shares. He is the director. He donates a share to the company. Now he has two shares and I am the director.

[crericha]

@physic, what's the expected behavior if two other players, neither the acting player, have the same number of shares? Like it is now?

[physic]

It appears to be unspecified in the current version of the rules. I can think of at least two interpretations with different outcomes. I've asked JC. I'm sure he'll have a clear answer/ruling for me soon.

[crericha]

@physic any word from JC? I'll fix once we clarify all cases.