tobychui
Update README.md
Updated the Docker Compose file to reflect the proper way of handling environment variables, especially since v. 3.0.9 introduces a breaking change compared to the composing file's previous example.
the PORT: "8005" format is equivalent to the - PORT=8005 and, in my opinion, the former looks much better so I would like to keep that
@PassiveLemon I wouldn't have suggested it If I hadn't noticed that using the former format lead to the loss of functionality of the container. Anyway, more tests are underway since I believe I found a bug with that particular variable exposed (docker compose + portainer)
@PassiveLemon Also, that would not explain the presence of this note in the docker-compose file in the repository:
Why making a clear point about not using the colon in the port flag, if it doesn't cause an issue? I think this should be re-evaluated.
That is noted for usage with Docker run, hence the use of CLI operators in the table above it but I can add a note for Docker compose usage too, thanks for catching that
Why making a clear point about not using the colon in the port flag, if it doesn't cause an issue?
Including a colon does cause issues because of how Zoraxy uses the port argument internally. When the colon is included, the healthcheck command would be nc -vz 127.0.0.1 :8000 which is incorrect. However, when the PORT variable is passed to Zoraxy as a CLI argument, the colon is prepended: -port=:${PORT}
I wouldn't have suggested it If I hadn't noticed that using the former format lead to the loss of functionality of the container.
I'm not exactly sure how the format of the environment attribute would lead to a loss of functionality. What functionality is lost? Please do update us about that