RenderPipeline icon indicating copy to clipboard operation
RenderPipeline copied to clipboard

Contribution - New Chromatic Aberration Options

Open RayaneLehnemann opened this issue 8 years ago • 1 comments

Hello, it's me again!

Here is another contribution for project, here is a new variation of Chromatic Aberration Shader, no i add two another options from rendering.

Linear Distortion lineardistortion Into this distortion type the R and B offset are the same in all screen.

Radial Distortion radialdistortion Into this distortion type the R and B offset become more stronger into the screen border's and more week into center.

Lens Distortion This is a standard Render Pipeline Chromatic Aberration.

Link to Shader: Chromatic Aberration for RP.zip

RayaneLehnemann avatar Jan 01 '17 18:01 RayaneLehnemann

Hi!

First of all, thanks for your contribution! There are a few things I noticed:

  • You don't need to redefine the distance method, its a builtin GLSL method
  • The naming of the variables is inconsistent, the render pipeline uses camel_case for glsl variable names (also some spaces are missing, but just nitpicking here)
  • The distortion should probably also depend on the chromatic abberation strength setting, as the second option does
  • The distortion type should also be a plugin setting, so its configurable via the plugin configurator (For reference, seehttps://github.com/tobspr/RenderPipeline/blob/master/rpplugins/ao/config.yaml#L59 and its glsl code here: https://github.com/tobspr/RenderPipeline/blob/master/rpplugins/ao/shader/ao_sample.frag.glsl#L81 )

Best regards, Tobias

tobspr avatar Jan 02 '17 18:01 tobspr