shapez.io icon indicating copy to clipboard operation
shapez.io copied to clipboard

Gulp `imgres.buildAtlas` not throw if java not installed

Open ArtemNikolaev opened this issue 9 months ago • 3 comments

There's a minor issue with gulp builder on task imgres.buildAtlas

image

in case to check java availability code running comand "java -version". Issue is that no error will be shown if java not installed.

So, the good idea to add more clear check of java version, which will show error when you trying to do this task without java installed.

ArtemNikolaev avatar Sep 06 '23 09:09 ArtemNikolaev

child_process.execSync will throw if there is an error though, as written at https://nodejs.org/api/child_process.html#child_processexecsynccommand-options

or were you running this yourself and it didn't error for you? If so, could you send logs?

EmeraldBlock avatar Sep 06 '23 11:09 EmeraldBlock

@EmeraldBlock I think java -version don't thow any error: image As you can see, no changes in colors or something, just info about which packages can be installed

ArtemNikolaev avatar Oct 05 '23 19:10 ArtemNikolaev

@ArtemNikolaev oh sorry, I meant non-zero exit code (which you can display by running echo $?, I think)

EmeraldBlock avatar Oct 05 '23 23:10 EmeraldBlock