shapez.io
shapez.io copied to clipboard
Gulp `imgres.buildAtlas` not throw if java not installed
There's a minor issue with gulp builder on task imgres.buildAtlas
in case to check java
availability code running comand "java -version".
Issue is that no error will be shown if java not installed.
So, the good idea to add more clear check of java version, which will show error when you trying to do this task without java installed.
child_process.execSync
will throw if there is an error though, as written at https://nodejs.org/api/child_process.html#child_processexecsynccommand-options
or were you running this yourself and it didn't error for you? If so, could you send logs?
@EmeraldBlock
I think java -version
don't thow any error:
As you can see, no changes in colors or something, just info about which packages can be installed
@ArtemNikolaev
oh sorry, I meant non-zero exit code (which you can display by running echo $?
, I think)