[crash]

[pipposo]

http://pastebin.com/FSJB7bPK

I sometimes crashes, you can see how best to string?

[tobmaps]

i can't even image what can be wrong with these checks... but you can try to replace

if (m_spellInfo->SpellFamilyName == SPELLFAMILY_WARLOCK && m_spellInfo->Category == 1179)

by

if (this && target && m_spellInfo && m_spellInfo->SpellFamilyName == SPELLFAMILY_WARLOCK && m_spellInfo->Category == 1179)

let me know if it helps or no Maybe check for "this" isn't needed here

[pipposo]

ok, I try and let you know, in the meantime thanks

[maxxx]

this - всегда существует, это из самой логики. А краш от какого-нибудь скрипта какого-нибудь школьника, у меня такого краша не было никогда. If it won't helps, try to find from where Spell::CheckTargetCreatureType called or get spell id

[pipposo]

your patch seems to work, I hold you up to date.

excuse for closing, I'm wrong button ^ ^

[pipposo]

crash http://pastebin.com/Rgr3P3Un

[2010phenix]

hm strange whet is this? spellCreatureTargetMask = error reading variable spellCreatureTargetMask (Unhandled dwarf expression opcode 0x0)

[pipposo]

tobmaps another type crash, please you can see http://pastebin.com/E3LfK7fv

[tobmaps]

try to replace your check by

// not to dead and not for dead
if (!pVictim->isAlive() || !getOwner() || !getOwner()->isAlive())
    return;

[pipposo]

ok...try

[pipposo]

another....ufff http://pastebin.com/8wzqTmZ2

ThreatManager.cpp:556 = iThreatContainer.remove(hostilReference); ThreatManager.h:157 = void remove(HostileReference* pRef) { iThreatList.remove(pRef); } ThreatManager.cpp:141 = getSource()->processThreatEvent(&pThreatRefStatusChangeEvent); ThreatManager.cpp:214 = fireStatusChanged(event); HostileRefManager.cpp:96 = ref->setOnlineOfflineState(bIsOnline);

[pipposo]

Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffccfff700 (LWP 23191)] 0x00000000007c83b4 in ThreatManager::addThreat (this=0x7fff6329eb20, pVictim=0x7fff9ea97000, fThreat=0, schoolMask=SPELL_SCHOOL_MASK_NORMAL, pThreatSpell=0x0) at /home/staff_fenice/install/fenicenew/fenicenew/src/server/game/Combat/ThreatManager.cpp:425 425 if (!pVictim->isAlive() || !getOwner() || !getOwner()->isAlive())

[tobmaps]

try this

if (!pVictim->IsInWorld() || !pVictim->isAlive()  || !getOwner() || !getOwner()->IsInWorld() || !getOwner()->isAlive())

[pipposo]

try...

[pipposo]

/home/trinitycore/install/trinitycore/trinitycore/src/server/game/Combat/ThreatManager.cpp: In member function 'void ThreatManager::addThreat(Unit_, float, SpellSchoolMask, const SpellEntry_)': /home/trinitycore/install/trinitycore/trinitycore/src/server/game/Combat/ThreatManager.cpp:425: error: 'IsInWorld' was not declared in this scope [ 14%] Built target pch_Generate_scripts make[2]: *** [src/server/game/CMakeFiles/game.dir/Combat/ThreatManager.cpp.o] Error 1

[tobmaps]

edited prev post, try new one

[pipposo]

error

[2010phenix]

i think problem not here i use some fixes for hunter\pet and see similar crash with lost treat and etc... but from another spell for now not time to look closer

[pipposo]

try if (this && target && m_spellInfo && m_spellInfo->SpellFamilyName == SPELLFAMILY_WARLOCK && m_spellInfo->Category == 1179) and crash help me tobmaps

[tobmaps]

if you has fresh crash dump then post it, because line numbers is changed...

[pipposo]

http://pastebin.com/tkcpTraB

thx tobmaps ^^

[tobmaps]

target=0x0 -_- i don't know how it can crash with your current checks :/

[pipposo]

ok :-(

[pipposo]

another crash, can you help? http://pastebin.com/Yz9YQJqZ

[2010phenix]

somwhere over code(patch) lost check HostileReference::updateOnlineStatus creature = 0x0

revert it half by half and you find than write in issue