TrinityCore icon indicating copy to clipboard operation
TrinityCore copied to clipboard

[Warrior] T10 4P Bonus

Open Jildor opened this issue 13 years ago • 13 comments

It's bug

I think this fix solves:

http://www.trinitycore.org/t/trinitycore/ticket/449#comment:7

Jildor avatar Apr 18 '11 09:04 Jildor

this patch isn't working properly. I does remove all charges at using Slam and Execute and Slam proc doesn't has 2 charges

tobmaps avatar Apr 21 '11 11:04 tobmaps

Oks.

So, any solution?

thx

Jildor avatar Apr 21 '11 14:04 Jildor

it's not so easy to fix charge consuming for this... I'm no planning to fix it for a while, i more prefer to fix talents and player spells ^^

tobmaps avatar Apr 21 '11 15:04 tobmaps

mmmm

Are you applied the sql to patch? http://www.trinitycore.org/t/trinitycore/attachment/ticket/449/patch.sql I think works.

Jildor avatar Apr 21 '11 15:04 Jildor

yes i've applied this, but anyway this SQL will not fix bugs that i meant before

tobmaps avatar Apr 21 '11 16:04 tobmaps

I count as 2 charges and I removed one at a time....I don't know :S

Jildor avatar Apr 21 '11 16:04 Jildor

important bug, waiting for fix.

kbinside avatar May 19 '11 16:05 kbinside

possible fix? https://github.com/SignFinder/FaceCore/commit/085c8d8d17bfd92595db8a47ec3d93e622be9ef8

Jildor avatar Jun 05 '11 15:06 Jildor

great, add this.

kbinside avatar Jun 05 '11 15:06 kbinside

this fix is a one big hack, correct solution can be done when QAston will done his new proc system

tobmaps avatar Jun 05 '11 15:06 tobmaps

its about time, to make this bonus working?

kbinside avatar Jun 21 '11 16:06 kbinside

better to wait for implementation of new proc system by QAston and only then try to fix it. For now you can easily use any hack that you want, i just will not review it

tobmaps avatar Jun 21 '11 17:06 tobmaps

okey, keep waiting.

maybe you can check: https://github.com/TrinityCore/TrinityCore/issues/2014 thanks

kbinside avatar Jun 21 '11 17:06 kbinside