kirby-seo icon indicating copy to clipboard operation
kirby-seo copied to clipboard

Published 20 hours ago • verified publisher icon tobimori

Field label language fallback doesn't work

Open olach opened this issue 1 year ago • 3 comments

If the panel user has a language that is not included as a translation for this plugin, the field labels shows the label keys instead of a fallback translation.

To reproduce:

  • For the currently logged in user, set the user language to a language that is not supported by this plugin, i.e. Swedish.
  • Go to a page and show the SEO tab.
  • All field labels shows the label key: global-meta-headline, meta-title-template, meta-title-template-help, meta-description etc

image

I would rather see that if the user language is not supported, the fallback would be shown with English translation.

olach avatar Nov 07 '24 13:11 olach

This doesn't seem like a plugin issue but rather an issue of core. Surely it should work by default? https://github.com/getkirby/kirby/issues/1188

tobimori avatar Nov 07 '24 15:11 tobimori

I was also thinking it might be a Kirby issue. Forgot to mention that. But because of this issue I took the time to make a PR with a swedish translation. So something good came out of it. 😄

olach avatar Nov 07 '24 19:11 olach

I have the same issue here, also in your dreamform plugin. Seems indeed to be a core issue: https://forum.getkirby.com/t/missing-translation-strings-from-plugins/33618

samlinck avatar Feb 14 '25 14:02 samlinck