kirby-dreamform icon indicating copy to clipboard operation
kirby-dreamform copied to clipboard

fix: add App namespace for Kirby\Cms\App in email templates

Open nerdcel opened this issue 6 months ago • 1 comments

Summary by CodeRabbit

  • Chores
    • Internal improvements to email templates for better maintainability. No visible changes to email content or functionality.

nerdcel avatar Apr 30 '25 07:04 nerdcel

Walkthrough

The changes add a use Kirby\Cms\App statement at the top of two PHP email template files. This update allows the templates to reference the App class directly without specifying its full namespace. No other content, logic, or structure within the templates has been altered.

Changes

File(s) Change Summary
templates/emails/dreamform.html.php,
templates/emails/dreamform.php
Added use Kirby\Cms\App at the top of each template to allow direct reference to the App class. No other changes.

Poem

Two templates, once a little shy,
Now call on Kirby’s App up high.
No more namespaces, long and grand,
Just use at top, as Linus planned.
Code’s a bit cleaner, no need to clap—
But hey, at least it’s less of a trap.
🐧


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4365dd0dd34aa4058dafb805774eb3e4c98b355c and d0a32bb952beac91eb63d1a138dc0140a576e51e.

📒 Files selected for processing (2)
  • templates/emails/dreamform.html.php (1 hunks)
  • templates/emails/dreamform.php (1 hunks)
🔇 Additional comments (2)
templates/emails/dreamform.php (1)

1-1: Straightforward import – LGTM.
Adding use Kirby\Cms\App; at the top brings App into the template’s namespace and lets you call App::instance() without the fully qualified path.

templates/emails/dreamform.html.php (1)

1-1: Namespace import is correct.
The use Kirby\Cms\App; declaration before your HTML doctype ensures the App class is available for those inline PHP blocks. Good to go.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 30 '25 07:04 coderabbitai[bot]

Thanks for the PR! I've gone ahead and implemented the changes manually to avoid any hiccups with the MJML build process.

tobimori avatar Jun 03 '25 14:06 tobimori