teslamateapi
teslamateapi copied to clipboard
Feature: adding address details
- added AddressDetails for all endpoints
- ~changing string to NullString for carName~
- ~fixing NullString~
original PR by @vbarrier: https://github.com/tobiasehlert/teslamateapi/pull/212
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
27.6% Duplication
@vbarrier, run some tests and the queries don't seem to be fully working.
I noticed for instance that the house_number
is returned in end_address
but not in end_address_details.house_number
.
We need to fix this before merging.. but I think I'll merge the NullString part separately first, since new users encounter issues with TeslaMateApi when not setting a carname :)
I noticed for instance that the
house_number
is returned inend_address
but not inend_address_details.house_number
.
Checked against a geofenced address and not another.. therefore the parameters on the address details section can be faulty 🤔
Moved CarName fix to #242.
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
35.7% Duplication
Catch issues before they fail your Quality Gate with our IDE extension
SonarLint
Thank you for fixing carName null bug :)
I will have a look on the house_number thing