teslamateapi icon indicating copy to clipboard operation
teslamateapi copied to clipboard

Feature: adding address details

Open tobiasehlert opened this issue 1 year ago • 7 comments

  • added AddressDetails for all endpoints
  • ~changing string to NullString for carName~
  • ~fixing NullString~

original PR by @vbarrier: https://github.com/tobiasehlert/teslamateapi/pull/212

tobiasehlert avatar Jun 12 '23 10:06 tobiasehlert

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
27.6% 27.6% Duplication

sonarqubecloud[bot] avatar Jun 12 '23 10:06 sonarqubecloud[bot]

@vbarrier, run some tests and the queries don't seem to be fully working.

I noticed for instance that the house_number is returned in end_address but not in end_address_details.house_number.

We need to fix this before merging.. but I think I'll merge the NullString part separately first, since new users encounter issues with TeslaMateApi when not setting a carname :)

tobiasehlert avatar Sep 22 '23 12:09 tobiasehlert

I noticed for instance that the house_number is returned in end_address but not in end_address_details.house_number.

Checked against a geofenced address and not another.. therefore the parameters on the address details section can be faulty 🤔

tobiasehlert avatar Sep 22 '23 14:09 tobiasehlert

Moved CarName fix to #242.

tobiasehlert avatar Sep 22 '23 15:09 tobiasehlert

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
35.7% 35.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Sep 22 '23 15:09 sonarqubecloud[bot]

Thank you for fixing carName null bug :)

vbarrier avatar Sep 23 '23 21:09 vbarrier

I will have a look on the house_number thing

vbarrier avatar Sep 23 '23 21:09 vbarrier