Feature: incomplete charges

[tobiasehlert]

Feature to show incomplete charges and handle them slightly different.

Original PR: https://github.com/tobiasehlert/teslamateapi/pull/93

[sonarcloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
42.6% Duplication

[tobiasehlert]

@alecdoconnor, now you can specify the docker imager with tobiasehlert/teslamateapi:feature-incomplete-charges and see if it behaves like you expect it to.

Btw, something similar interesting for incomplete drives?

[alecdoconnor]

Hey! I actually tested this with a local build, once I figured out how! It worked great for me.

What did you mean by, "Btw, something similar interesting for incomplete drives?"

[tobiasehlert]

Hey! I actually tested this with a local build, once I figured out how! It worked great for me.

Ok great! I will testrun it and see if I get the same thing. First I got to find some charges that are not completed.. that's the first mission :P

What did you mean by, "Btw, something similar interesting for incomplete drives?"

I thought that it maybe could happen that even a drive is incomplete the same way as a charge. Therefore the question.. but oyu might not have experienced anything like that?

[alecdoconnor]

If you want to generate a few incomplete charges, run this API call while you're charging, or shut down TM after a charge started but before it finishes, and start it back up after you unplug.

Good point about the drives! I have not experienced incomplete drives, but I am curious if they could be created in a similar manner to how I created the incomplete charges, as mentioned above. In theory, it's possible to be missing drives if TM is down for some time. It would be easy to detect, since we would just review the car's mileage between drives. When I have some time, I'll do some research!

Thanks, Alec

On Mon, Oct 11, 2021 at 7:50 AM Tobias Lindberg @.***> wrote:

Hey! I actually tested this with a local build, once I figured out how! It worked great for me.

Ok great! I will testrun it and see if I get the same thing. First I got to find some charges that are not completed.. that's the first mission :P

What did you mean by, "Btw, something similar interesting for incomplete drives?"

I thought that it maybe could happen that even a drive is incomplete the same way as a charge. Therefore the question.. but oyu might not have experienced anything like that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tobiasehlert/teslamateapi/pull/109#issuecomment-939957162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4CZXTZ4BAAP2FF62C5Y53UGLFQ5ANCNFSM5FYAOLOQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[tobiasehlert]

Hi @alecdoconnor,

My wife went driving today while I was at the computer and checked.. there is no active drive ongoing when driving, so that seems to be inserted first when completed. So based on that, this should only be implemented for charging.. I'll check today evening when charging the car at 23:00 :)

Regards, Tobias

[tobiasehlert]

Hi @alecdoconnor,

My car is currently charging and I can't see an entry for the ongoing charge in the charges list and also when using the supposed to be added ID, it's not returning anything for me. So I can't see to get the same issue as you got 🤔

Regards, Tobias

[alecdoconnor]

Is this on the feature branch? As for the list, it should be part of a separate array so it doesn't cause a conflict with existing API deserializations. But why the detailed charge isn't working, I have no idea! They both seem to still be working for me. When the charge finishes, will you see if it shows up like normal and with the expected start time?

Alec

On Mon, Nov 8, 2021 at 8:12 PM Tobias Lindberg @.***> wrote:

Hi @alecdoconnor https://github.com/alecdoconnor,

My car is currently charging and I can't see an entry for the ongoing charge in the charges list and also when using the supposed to be added ID, it's not returning anything for me. So I can't see to get the same issue as you got 🤔

Regards, Tobias

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tobiasehlert/teslamateapi/pull/109#issuecomment-963721487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4CZXSVD6F7APK5PY6X67TULBYQDANCNFSM5FYAOLOQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.